scientific-witchery/pds-dash
3
0
Fork 0
Code Issues 2 Pull requests Projects 1 Releases 1 Packages Wiki Activity Actions

Fix users with no profile record not being shown #7

Merged
astra merged 5 commits from kc/profileless-users-not-being-shown into main 2025-05-30 03:05:06 +00:00
Conversation 5 Commits 5 Files changed 4 +35 -13
astra commented 2025-05-14 12:52:36 +00:00
Owner
Copy link
No description provided.
astra added 2 commits 2025-05-14 12:52:36 +00:00
kc was assigned by astra 2025-05-14 12:52:43 +00:00
astra reviewed 2025-05-14 12:55:08 +00:00
src/lib/AccountComponent.svelte
@ -15,0 +17,4 @@
</div>
{:else}
<div id="accountName" class="no-avatar">
{account.displayName || account.handle || account.did}
astra commented 2025-05-14 12:54:32 +00:00
Author
Owner
Copy link

Idk about the styling change, needs a further discussion (prolly as part of a bigger config update)

Idk about the styling change, needs a further discussion (prolly as part of a bigger config update)
kc commented 2025-05-15 11:07:02 +00:00
Owner
Copy link

In the chat you said that it'd be better to not align avatarless users and keep them small, should I do that now?

In the chat you said that it'd be better to not align avatarless users and keep them small, should I do that now?
astra marked this conversation as resolved
src/lib/pdsfetch.ts Outdated
@ -133,6 +133,13 @@ const getAccountMetadata = async (
did: `did:${string}:${string}`,
) => {
// gonna assume self exists in the app.bsky.actor.profile
astra commented 2025-05-14 12:53:25 +00:00
Author
Owner
Copy link

Is this comment still valid?

Is this comment still valid?
kc commented 2025-05-15 11:04:44 +00:00
Owner
Copy link

No, not really. I forgot to remove it, sorry!
I'll clean up some things a bit now

No, not really. I forgot to remove it, sorry! I'll clean up some things a bit now
kc marked this conversation as resolved
kc added 1 commit 2025-05-15 11:14:22 +00:00
astra commented 2025-05-29 11:22:24 +00:00
Author
Owner
Copy link

I'll return to this tomorrow, the theming/config update is finally done

I'll return to this tomorrow, the theming/config update is finally done
astra added 1 commit 2025-05-30 02:30:33 +00:00
astra commented 2025-05-30 02:31:14 +00:00
Author
Owner
Copy link

@kc @ari review お願い致します

@kc @ari review お願い致します
astra self-assigned this 2025-05-30 02:32:31 +00:00
ari added 1 commit 2025-05-30 02:47:58 +00:00
ari commented 2025-05-30 02:49:55 +00:00
Owner
Copy link

Looks fine

Looks fine
ari approved these changes 2025-05-30 03:03:42 +00:00
ari left a comment
Owner
Copy link

So full of accounts without self yum

So full of accounts without self yum
astra merged commit c348ed5d46 into main 2025-05-30 03:05:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ari
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
kc
astra
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: scientific-witchery/pds-dash#7
No description provided.
Delete branch "kc/profileless-users-not-being-shown"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?